lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[IPV4/IPV6/DECNET]: Small cleanup for fib rules.

Browse Source 
This patch slightly cleanups FIB rules framework. rules_list as a pointer
on struct fib_rules_ops is useless. It is always assigned with a static
per/subsystem list in IPv4, IPv6 and DecNet.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Acked-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Denis V. Lunev
2007-09-16 15:44:27 -07:00
committed by David S. Miller
parent 056925ab31
commit 76c72d4f44
5 changed files with 28 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
net/decnet/dn_rules.c
View File

@@ -57,8 +57,6 @@ static struct dn_fib_rule default_rule = {
},
};
static LIST_HEAD(dn_fib_rules);
int dn_fib_lookup(struct flowi *flp, struct dn_fib_res *res)
{
@@ -228,9 +226,9 @@ static u32 dn_fib_rule_default_pref(void)
struct list_head *pos;
struct fib_rule *rule;
if (!list_empty(&dn_fib_rules)) {
pos = dn_fib_rules.next;
if (pos->next != &dn_fib_rules) {
if (!list_empty(&dn_fib_rules_ops.rules_list)) {
pos = dn_fib_rules_ops.rules_list.next;
if (pos->next != &dn_fib_rules_ops.rules_list) {
rule = list_entry(pos->next, struct fib_rule, list);
if (rule->pref)
return rule->pref - 1;
@@ -258,13 +256,14 @@ static struct fib_rules_ops dn_fib_rules_ops = {
.flush_cache = dn_fib_rule_flush_cache,
.nlgroup = RTNLGRP_DECnet_RULE,
.policy = dn_fib_rule_policy,
.rules_list = &dn_fib_rules,
.rules_list = LIST_HEAD_INIT(dn_fib_rules_ops.rules_list),
.owner = THIS_MODULE,
};
void __init dn_fib_rules_init(void)
{
list_add_tail(&default_rule.common.list, &dn_fib_rules);
list_add_tail(&default_rule.common.list,
&dn_fib_rules_ops.rules_list);
fib_rules_register(&dn_fib_rules_ops);
}