lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[media] gspca_cpia1: Don't allow the framerate divisor to go above 2

Browse Source 
Having a framerate divisor of 3 is not really necesarry and leads to
various troubles (frames going missing, compression issues) when allowed.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Hans de Goede
2011-02-21 11:30:30 -03:00
committed by Mauro Carvalho Chehab
parent 49b61ec9b5
commit 76fafe78df
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/video/gspca/cpia1.c
View File

@@ -1,7 +1,7 @@
/* /*
* cpia CPiA (1) gspca driver * cpia CPiA (1) gspca driver
* *
* Copyright (C) 2010 Hans de Goede <hdegoede@redhat.com> * Copyright (C) 2010-2011 Hans de Goede <hdegoede@redhat.com>
* *
* This module is adapted from the in kernel v4l1 cpia driver which is : * This module is adapted from the in kernel v4l1 cpia driver which is :
* *
@@ -1400,7 +1400,7 @@ static void monitor_exposure(struct gspca_dev *gspca_dev)
if ((sd->exposure_status == EXPOSURE_VERY_DARK || if ((sd->exposure_status == EXPOSURE_VERY_DARK ||
sd->exposure_status == EXPOSURE_DARK) && sd->exposure_status == EXPOSURE_DARK) &&
sd->exposure_count >= DARK_TIME * framerate && sd->exposure_count >= DARK_TIME * framerate &&
sd->params.sensorFps.divisor < 3) { sd->params.sensorFps.divisor < 2) {
/* dark for too long */ /* dark for too long */
++sd->params.sensorFps.divisor; ++sd->params.sensorFps.divisor;
@@ -1456,7 +1456,7 @@ static void monitor_exposure(struct gspca_dev *gspca_dev)
if ((sd->exposure_status == EXPOSURE_VERY_DARK || if ((sd->exposure_status == EXPOSURE_VERY_DARK ||
sd->exposure_status == EXPOSURE_DARK) && sd->exposure_status == EXPOSURE_DARK) &&
sd->exposure_count >= DARK_TIME * framerate && sd->exposure_count >= DARK_TIME * framerate &&
sd->params.sensorFps.divisor < 3) { sd->params.sensorFps.divisor < 2) {
/* dark for too long */ /* dark for too long */
++sd->params.sensorFps.divisor; ++sd->params.sensorFps.divisor;