lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging/xgifb: Remove duplicated code in loops.

Browse Source 
Instead of calling the same function three times in a loop, multiply the
loop counter by three.
And since the value in DAC_TEST_PARMS is always the same we can use the
value directly.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Peter Huewe 2013-02-15 20:37:13 +01:00 committed by Greg Kroah-Hartman
parent 053004b375
commit 771f3eed63
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/xgifb/vb_setmode.c
View File

@ -5464,7 +5464,6 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
unsigned char CR17, CR63, SR31;
unsigned short temp;
unsigned char DAC_TEST_PARMS[3] = { 0x0F, 0x0F, 0x0F };
int i;
xgifb_reg_set(pVBInfo->P3c4, 0x05, 0x86);
@ -5518,10 +5517,8 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
outb(0x00, pVBInfo->P3c8);
for (i = 0; i < 256; i++) {
outb((unsigned char) DAC_TEST_PARMS[0], (pVBInfo->P3c8 + 1));
outb((unsigned char) DAC_TEST_PARMS[1], (pVBInfo->P3c8 + 1));
outb((unsigned char) DAC_TEST_PARMS[2], (pVBInfo->P3c8 + 1));
for (i = 0; i < 256 * 3; i++) {
outb(0x0F, (pVBInfo->P3c8 + 1)); /* DAC_TEST_PARMS */
}
mdelay(1);
@ -5537,9 +5534,7 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
/* avoid display something, set BLACK DAC if not restore DAC */
outb(0x00, pVBInfo->P3c8);
for (i = 0; i < 256; i++) {
outb(0, (pVBInfo->P3c8 + 1));
outb(0, (pVBInfo->P3c8 + 1));
for (i = 0; i < 256 * 3; i++) {
outb(0, (pVBInfo->P3c8 + 1));
}