e1000: implement more efficient tx queue locking
Implement more efficient locking (avoid the lock) when checking for a stopped queue. Also don't wake the queue unless the threshold is reached to avoid queue on/off thrash. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> Signed-off-by: John Ronciak <john.ronciak@intel.com>
This commit is contained in:
@@ -3400,13 +3400,15 @@ e1000_clean_tx_irq(struct e1000_adapter *adapter,
|
|||||||
|
|
||||||
tx_ring->next_to_clean = i;
|
tx_ring->next_to_clean = i;
|
||||||
|
|
||||||
spin_lock(&tx_ring->tx_lock);
|
#define TX_WAKE_THRESHOLD 32
|
||||||
|
|
||||||
if (unlikely(cleaned && netif_queue_stopped(netdev) &&
|
if (unlikely(cleaned && netif_queue_stopped(netdev) &&
|
||||||
netif_carrier_ok(netdev)))
|
netif_carrier_ok(netdev))) {
|
||||||
netif_wake_queue(netdev);
|
spin_lock(&tx_ring->tx_lock);
|
||||||
|
if (netif_queue_stopped(netdev) &&
|
||||||
spin_unlock(&tx_ring->tx_lock);
|
(E1000_DESC_UNUSED(tx_ring) >= TX_WAKE_THRESHOLD))
|
||||||
|
netif_wake_queue(netdev);
|
||||||
|
spin_unlock(&tx_ring->tx_lock);
|
||||||
|
}
|
||||||
|
|
||||||
if (adapter->detect_tx_hung) {
|
if (adapter->detect_tx_hung) {
|
||||||
/* Detect a transmit hang in hardware, this serializes the
|
/* Detect a transmit hang in hardware, this serializes the
|
||||||
|
Reference in New Issue
Block a user