dm table: print error on preresume failure
If preresume fails it is worth logging an error given that a device is left suspended due to the failure. This change was motivated by local preresume error logging that was added to the cache target ("preresume failed"). Elevating this target-agnostic context for the where the target-specific error occurred relative to the DM core's callouts makes sense. Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Joe Thornber <ejt@redhat.com>
This commit is contained in:
@@ -1562,9 +1562,12 @@ int dm_table_resume_targets(struct dm_table *t)
|
|||||||
continue;
|
continue;
|
||||||
|
|
||||||
r = ti->type->preresume(ti);
|
r = ti->type->preresume(ti);
|
||||||
if (r)
|
if (r) {
|
||||||
|
DMERR("%s: %s: preresume failed, error = %d",
|
||||||
|
dm_device_name(t->md), ti->type->name, r);
|
||||||
return r;
|
return r;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
for (i = 0; i < t->num_targets; i++) {
|
for (i = 0; i < t->num_targets; i++) {
|
||||||
struct dm_target *ti = t->targets + i;
|
struct dm_target *ti = t->targets + i;
|
||||||
|
Reference in New Issue
Block a user