lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

svcrpc: don't hold sv_lock over svc_xprt_put()

Browse Source 
svc_xprt_put() can call tcp_close(), which can sleep, so we shouldn't be
holding this lock.

In fact, only the xpt_list removal and the sv_tmpcnt decrement should
need the sv_lock here.

Reported-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
This commit is contained in:
J. Bruce Fields
2010-03-29 21:02:31 -04:00
parent a5990ea125
commit 788e69e548
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/sunrpc/svc_xprt.c
View File

@@ -892,12 +892,12 @@ void svc_delete_xprt(struct svc_xprt *xprt)
*/ */
if (test_bit(XPT_TEMP, &xprt->xpt_flags)) if (test_bit(XPT_TEMP, &xprt->xpt_flags))
serv->sv_tmpcnt--; serv->sv_tmpcnt--;
spin_unlock_bh(&serv->sv_lock);
while ((dr = svc_deferred_dequeue(xprt)) != NULL) while ((dr = svc_deferred_dequeue(xprt)) != NULL)
kfree(dr); kfree(dr);
svc_xprt_put(xprt); svc_xprt_put(xprt);
spin_unlock_bh(&serv->sv_lock);
} }
void svc_close_xprt(struct svc_xprt *xprt) void svc_close_xprt(struct svc_xprt *xprt)