lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bnx2x: use list_move_tail instead of list_del/list_add_tail

Browse Source 
Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wei Yongjun
2012-09-04 21:06:55 +00:00
committed by David S. Miller
parent 2c96932229
commit 7933aa5c75
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
View File

@@ -229,8 +229,7 @@ static inline int bnx2x_exe_queue_step(struct bnx2x *bp,
*/ */
list_add_tail(&spacer.link, &o->pending_comp); list_add_tail(&spacer.link, &o->pending_comp);
mb(); mb();
list_del(&elem->link); list_move_tail(&elem->link, &o->pending_comp);
list_add_tail(&elem->link, &o->pending_comp);
list_del(&spacer.link); list_del(&spacer.link);
} else } else
break; break;