lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fs: use list_for_each_entry_reverse and kill sb_entry

Browse Source 
Use list_for_each_entry_reverse for super_blocks list and remove
unused sb_entry macro.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Akinobu Mita
2008-02-06 01:37:08 -08:00
committed by Linus Torvalds
parent e8462caa91
commit 797074e44d
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/fs-writeback.c
View File

@@ -515,8 +515,7 @@ writeback_inodes(struct writeback_control *wbc)
might_sleep(); might_sleep();
spin_lock(&sb_lock); spin_lock(&sb_lock);
restart: restart:
sb = sb_entry(super_blocks.prev); list_for_each_entry_reverse(sb, &super_blocks, s_list) {
for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.prev)) {
if (sb_has_dirty_inodes(sb)) { if (sb_has_dirty_inodes(sb)) {
/* we're making our own get_super here */ /* we're making our own get_super here */
sb->s_count++; sb->s_count++;
@@ -581,10 +580,8 @@ static void set_sb_syncing(int val)
{ {
struct super_block *sb; struct super_block *sb;
spin_lock(&sb_lock); spin_lock(&sb_lock);
sb = sb_entry(super_blocks.prev); list_for_each_entry_reverse(sb, &super_blocks, s_list)
for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.prev)) {
sb->s_syncing = val; sb->s_syncing = val;
}
spin_unlock(&sb_lock); spin_unlock(&sb_lock);
} }

1
include/linux/fs.h
View File

@@ -977,7 +977,6 @@ extern int send_sigurg(struct fown_struct *fown);
extern struct list_head super_blocks; extern struct list_head super_blocks;
extern spinlock_t sb_lock; extern spinlock_t sb_lock;
#define sb_entry(list) list_entry((list), struct super_block, s_list)
#define S_BIAS (1<<30) #define S_BIAS (1<<30)
struct super_block { struct super_block {
struct list_head s_list; /* Keep this first */ struct list_head s_list; /* Keep this first */