lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dmxdev: get rid of pointless clearing ->f_op

Browse Source 
nobody else will see that struct file after return from ->release()
anyway; just leave ->f_op as is and let __fput() do that fops_put().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2013-09-22 14:33:32 -04:00
parent e84f9e57b9
commit 79b185dd1a
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/dvb-core/dmxdev.c
View File

@@ -206,8 +206,6 @@ static int dvb_dvr_release(struct inode *inode, struct file *file)
/* TODO */ /* TODO */
dvbdev->users--; dvbdev->users--;
if (dvbdev->users == 1 && dmxdev->exit == 1) { if (dvbdev->users == 1 && dmxdev->exit == 1) {
fops_put(file->f_op);
file->f_op = NULL;
mutex_unlock(&dmxdev->mutex); mutex_unlock(&dmxdev->mutex);
wake_up(&dvbdev->wait_queue); wake_up(&dvbdev->wait_queue);
} else } else
@@ -1120,8 +1118,6 @@ static int dvb_demux_release(struct inode *inode, struct file *file)
mutex_lock(&dmxdev->mutex); mutex_lock(&dmxdev->mutex);
dmxdev->dvbdev->users--; dmxdev->dvbdev->users--;
if(dmxdev->dvbdev->users==1 && dmxdev->exit==1) { if(dmxdev->dvbdev->users==1 && dmxdev->exit==1) {
fops_put(file->f_op);
file->f_op = NULL;
mutex_unlock(&dmxdev->mutex); mutex_unlock(&dmxdev->mutex);
wake_up(&dmxdev->dvbdev->wait_queue); wake_up(&dmxdev->dvbdev->wait_queue);
} else } else