lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[POWERPC] add check for initialized driver data to pmi driver

Browse Source 
This patch adds a check for the private driver data to be initialized.
The bug showed up, as the caller found a pmi device by it's type.
Whereas the pmi driver probes for the type and the name.
Since the name was not as the driver expected, it did not initialize.
A more relaxed probing will be supplied with an extra patch, too.

Signed-off-by: Christian Krafft <krafft@de.ibm.com>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
This commit is contained in:
Christian Krafft
2007-04-23 21:35:43 +02:00
committed by Arnd Bergmann
parent 5050063c04
commit 79baf4a60e
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
arch/powerpc/sysdev/pmi.c
View File

@@ -279,6 +279,9 @@ void pmi_register_handler(struct of_device *device,
struct pmi_data *data; struct pmi_data *data;
data = device->dev.driver_data; data = device->dev.driver_data;
if (!data)
return;
spin_lock(&data->handler_spinlock); spin_lock(&data->handler_spinlock);
list_add_tail(&handler->node, &data->handler); list_add_tail(&handler->node, &data->handler);
spin_unlock(&data->handler_spinlock); spin_unlock(&data->handler_spinlock);
@@ -289,11 +292,13 @@ void pmi_unregister_handler(struct of_device *device,
struct pmi_handler *handler) struct pmi_handler *handler)
{ {
struct pmi_data *data; struct pmi_data *data;
data = device->dev.driver_data;
if (!data)
return;
pr_debug("pmi: unregistering handler %p\n", handler); pr_debug("pmi: unregistering handler %p\n", handler);
data = device->dev.driver_data;
spin_lock(&data->handler_spinlock); spin_lock(&data->handler_spinlock);
list_del(&handler->node); list_del(&handler->node);
spin_unlock(&data->handler_spinlock); spin_unlock(&data->handler_spinlock);