wl1251: remove wait parameter from wl1251_cmd_join()
We should wait everytime for the join command to finish, not waiting for it might create problems. Signed-off-by: Kalle Valo <kalle.valo@nokia.com> Reviewed-by: Vidhya Govindan <vidhya.govindan@nokia.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
committed by
John W. Linville
parent
e2fd4611d5
commit
7a33732fd9
@ -252,7 +252,7 @@ out:
|
||||
}
|
||||
|
||||
int wl1251_cmd_join(struct wl1251 *wl, u8 bss_type, u16 beacon_interval,
|
||||
u8 dtim_interval, bool wait)
|
||||
u8 dtim_interval)
|
||||
{
|
||||
unsigned long timeout;
|
||||
struct cmd_join *join;
|
||||
@ -273,10 +273,9 @@ int wl1251_cmd_join(struct wl1251 *wl, u8 bss_type, u16 beacon_interval,
|
||||
if (ret < 0)
|
||||
goto out;
|
||||
|
||||
wl1251_debug(DEBUG_CMD, "cmd join%s %d %d%s",
|
||||
wl1251_debug(DEBUG_CMD, "cmd join%s %d %d",
|
||||
bss_type == BSS_TYPE_IBSS ? " ibss" : "",
|
||||
beacon_interval, dtim_interval,
|
||||
wait ? " wait" : "");
|
||||
beacon_interval, dtim_interval);
|
||||
|
||||
/* Reverse order BSSID */
|
||||
bssid = (u8 *) &join->bssid_lsb;
|
||||
@ -307,8 +306,7 @@ int wl1251_cmd_join(struct wl1251 *wl, u8 bss_type, u16 beacon_interval,
|
||||
* ugly hack: we should wait for JOIN_EVENT_COMPLETE_ID but to
|
||||
* simplify locking we just sleep instead, for now
|
||||
*/
|
||||
if (wait)
|
||||
msleep(10);
|
||||
msleep(10);
|
||||
|
||||
out:
|
||||
kfree(join);
|
||||
|
Reference in New Issue
Block a user