lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations

Browse Source 
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ben Hutchings
2009-09-03 10:39:43 +00:00
committed by David S. Miller
parent aae5e7c30f
commit 7ab0f2736b
30 changed files with 1 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/atl1c/atl1c_main.c
View File

@@ -534,10 +534,6 @@ static int atl1c_mii_ioctl(struct net_device *netdev,
break;
case SIOCGMIIREG:
if (!capable(CAP_NET_ADMIN)) {
retval = -EPERM;
goto out;
}
if (atl1c_read_phy_reg(&adapter->hw, data->reg_num & 0x1F,
&data->val_out)) {
retval = -EIO;
@@ -546,10 +542,6 @@ static int atl1c_mii_ioctl(struct net_device *netdev,
break;
case SIOCSMIIREG:
if (!capable(CAP_NET_ADMIN)) {
retval = -EPERM;
goto out;
}
if (data->reg_num & ~(0x1F)) {
retval = -EFAULT;
goto out;