lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations

Browse Source 
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ben Hutchings
2009-09-03 10:39:43 +00:00
committed by David S. Miller
parent aae5e7c30f
commit 7ab0f2736b
30 changed files with 1 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/r8169.c
View File

@ -1991,8 +1991,6 @@ static int rtl_xmii_ioctl(struct rtl8169_private *tp, struct mii_ioctl_data *dat
return 0;
case SIOCSMIIREG:
if (!capable(CAP_NET_ADMIN))
return -EPERM;
mdio_write(tp->mmio_addr, data->reg_num & 0x1f, data->val_in);
return 0;
}