lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations

Browse Source 
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ben Hutchings
2009-09-03 10:39:43 +00:00
committed by David S. Miller
parent aae5e7c30f
commit 7ab0f2736b
30 changed files with 1 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/sungem.c
View File

@@ -2852,9 +2852,7 @@ static int gem_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
break;
case SIOCSMIIREG: /* Write MII PHY register. */
if (!capable(CAP_NET_ADMIN))
rc = -EPERM;
else if (!gp->running)
if (!gp->running)
rc = -EAGAIN;
else {
__phy_write(gp, data->phy_id & 0x1f, data->reg_num & 0x1f,