lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

p54spi: Remove FIXME in op_stop

Browse Source 
Don't use the interruptible variant of mutex_lock(). It doesn't really
need to be interruptible. This avoids nasty error handling.

Signed-off-by: Michael Buesch <m@bues.ch>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Michael Büsch
2011-11-16 23:51:20 +01:00
committed by John W. Linville
parent fcac4fb00e
commit 7adb92faa8
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wireless/p54/p54spi.c
View File

@@ -581,11 +581,7 @@ static void p54spi_op_stop(struct ieee80211_hw *dev)
struct p54s_priv *priv = dev->priv; struct p54s_priv *priv = dev->priv;
unsigned long flags; unsigned long flags;
if (mutex_lock_interruptible(&priv->mutex)) { mutex_lock(&priv->mutex);
/* FIXME: how to handle this error? */
return;
}
WARN_ON(priv->fw_state != FW_STATE_READY); WARN_ON(priv->fw_state != FW_STATE_READY);
cancel_work_sync(&priv->work); cancel_work_sync(&priv->work);