lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ARM] omap: ensure that failing power domain lookups produce errors

Browse Source 
Use pr_err() for errors rather than pr_debug().  pr_debug() are
compiled away unless -DDEBUG is used.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
Russell King
2009-02-22 21:00:55 +00:00
committed by Russell King
parent 7eb1afc976
commit 7aec53acc0
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
arch/arm/mach-omap2/clockdomain.c
View File

@@ -74,14 +74,11 @@ static void _autodep_lookup(struct clkdm_pwrdm_autodep *autodep)
pwrdm = pwrdm_lookup(autodep->pwrdm.name); pwrdm = pwrdm_lookup(autodep->pwrdm.name);
if (!pwrdm) { if (!pwrdm) {
pr_debug("clockdomain: _autodep_lookup: powerdomain %s " pr_err("clockdomain: autodeps: powerdomain %s does not exist\n",
"does not exist\n", autodep->pwrdm.name); autodep->pwrdm.name);
WARN_ON(1);
pwrdm = ERR_PTR(-ENOENT); pwrdm = ERR_PTR(-ENOENT);
} }
autodep->pwrdm.ptr = pwrdm; autodep->pwrdm.ptr = pwrdm;
return;
} }
/* /*
@@ -211,8 +208,8 @@ int clkdm_register(struct clockdomain *clkdm)
pwrdm = pwrdm_lookup(clkdm->pwrdm.name); pwrdm = pwrdm_lookup(clkdm->pwrdm.name);
if (!pwrdm) { if (!pwrdm) {
pr_debug("clockdomain: clkdm_register %s: powerdomain %s " pr_err("clockdomain: %s: powerdomain %s does not exist\n",
"does not exist\n", clkdm->name, clkdm->pwrdm.name); clkdm->name, clkdm->pwrdm.name);
return -EINVAL; return -EINVAL;
} }
clkdm->pwrdm.ptr = pwrdm; clkdm->pwrdm.ptr = pwrdm;
@@ -222,7 +219,7 @@ int clkdm_register(struct clockdomain *clkdm)
if (_clkdm_lookup(clkdm->name)) { if (_clkdm_lookup(clkdm->name)) {
ret = -EEXIST; ret = -EEXIST;
goto cr_unlock; goto cr_unlock;
}; }
list_add(&clkdm->node, &clkdm_list); list_add(&clkdm->node, &clkdm_list);