lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

b43: Fix possible MMIO access while device is down

Browse Source 
This fixes a possible MMIO access while the device is still down
from a suspend cycle. MMIO accesses with the device powered down
may cause crashes on certain devices.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Michael Buesch
2008-06-15 16:01:24 +02:00
committed by John W. Linville
parent 664f200610
commit 7b3abfc87e
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/wireless/b43/leds.c
View File

@@ -72,6 +72,9 @@ static void b43_led_brightness_set(struct led_classdev *led_dev,
struct b43_wldev *dev = led->dev; struct b43_wldev *dev = led->dev;
bool radio_enabled; bool radio_enabled;
if (unlikely(b43_status(dev) < B43_STAT_INITIALIZED))
return;
/* Checking the radio-enabled status here is slightly racy, /* Checking the radio-enabled status here is slightly racy,
* but we want to avoid the locking overhead and we don't care * but we want to avoid the locking overhead and we don't care
* whether the LED has the wrong state for a second. */ * whether the LED has the wrong state for a second. */