lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] I2C: refactor message in i2c_detach_client

Browse Source 
We could refactor the error message 34 different i2c drivers print if
i2c_detach_client() fails in this function itself. Saves quite a few
lines of code. Documentation is updated to reflect that change.

Note that this patch should be applied after Rudolf Marek's w83792d
patches.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jean Delvare
2005-07-27 22:14:49 +02:00
committed by Greg Kroah-Hartman
parent 1ff4e3065b
commit 7bef559455
37 changed files with 42 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hwmon/lm63.c
View File

@ -520,11 +520,8 @@ static int lm63_detach_client(struct i2c_client *client)
hwmon_device_unregister(data->class_dev);
if ((err = i2c_detach_client(client))) {
dev_err(&client->dev, "Client deregistration failed, "
"client not detached\n");
if ((err = i2c_detach_client(client)))
return err;
}
kfree(data);
return 0;