lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

driver model: anti-oopsing medicine

Browse Source 
Anti-oops medicine for the class iterators ... the oops was
observed when a class was implicitly referenced before it
was initialized.

[Modified by Greg to spit a warning back so someone knows to fix their code]

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
David Brownell
2008-08-06 18:52:44 -07:00
committed by Greg Kroah-Hartman
parent bf9ca69fc8
commit 7c2250352e
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/base/class.c
View File

@@ -295,6 +295,12 @@ int class_for_each_device(struct class *class, struct device *start,
if (!class) if (!class)
return -EINVAL; return -EINVAL;
if (!class->p) {
WARN(1, "%s called for class '%s' before it was initialized",
__func__, class->name);
return -EINVAL;
}
mutex_lock(&class->p->class_mutex); mutex_lock(&class->p->class_mutex);
list_for_each_entry(dev, &class->p->class_devices, node) { list_for_each_entry(dev, &class->p->class_devices, node) {
if (start) { if (start) {
@@ -344,6 +350,11 @@ struct device *class_find_device(struct class *class, struct device *start,
if (!class) if (!class)
return NULL; return NULL;
if (!class->p) {
WARN(1, "%s called for class '%s' before it was initialized",
__func__, class->name);
return NULL;
}
mutex_lock(&class->p->class_mutex); mutex_lock(&class->p->class_mutex);
list_for_each_entry(dev, &class->p->class_devices, node) { list_for_each_entry(dev, &class->p->class_devices, node) {