configfs: register_filesystem() called too early

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2011-12-13 12:32:42 -05:00
parent 988f032567
commit 7c6455e368
2 changed files with 19 additions and 21 deletions

View File

@@ -292,7 +292,7 @@ int __init configfs_inode_init(void)
return bdi_init(&configfs_backing_dev_info); return bdi_init(&configfs_backing_dev_info);
} }
void __exit configfs_inode_exit(void) void configfs_inode_exit(void)
{ {
bdi_destroy(&configfs_backing_dev_info); bdi_destroy(&configfs_backing_dev_info);
} }

View File

@@ -143,28 +143,26 @@ static int __init configfs_init(void)
goto out; goto out;
config_kobj = kobject_create_and_add("config", kernel_kobj); config_kobj = kobject_create_and_add("config", kernel_kobj);
if (!config_kobj) { if (!config_kobj)
kmem_cache_destroy(configfs_dir_cachep); goto out2;
configfs_dir_cachep = NULL;
goto out;
}
err = register_filesystem(&configfs_fs_type);
if (err) {
printk(KERN_ERR "configfs: Unable to register filesystem!\n");
kobject_put(config_kobj);
kmem_cache_destroy(configfs_dir_cachep);
configfs_dir_cachep = NULL;
goto out;
}
err = configfs_inode_init(); err = configfs_inode_init();
if (err) { if (err)
unregister_filesystem(&configfs_fs_type); goto out3;
err = register_filesystem(&configfs_fs_type);
if (err)
goto out4;
return 0;
out4:
printk(KERN_ERR "configfs: Unable to register filesystem!\n");
configfs_inode_exit();
out3:
kobject_put(config_kobj); kobject_put(config_kobj);
out2:
kmem_cache_destroy(configfs_dir_cachep); kmem_cache_destroy(configfs_dir_cachep);
configfs_dir_cachep = NULL; configfs_dir_cachep = NULL;
}
out: out:
return err; return err;
} }