lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

spi: move common spi_setup() functionality into core

Browse Source 
Start moving some spi_setup() functionality into the SPI core from the
various spi_master controller drivers:

 - Make that function stop being an inline;

 - Move two common idioms from drivers into that new function:
    * Default bits_per_word to 8 if that field isn't set
    * Issue a standardized dev_dbg() message

This is a net minor source code shrink, and supports enhancments found in
some follow-up patches.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
David Brownell
2009-06-17 16:26:03 -07:00
committed by Linus Torvalds
parent b4bd2ababd
commit 7d0771970c
15 changed files with 61 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/spi/spi_imx.c
View File

@@ -1286,10 +1286,7 @@ static int setup(struct spi_device *spi)
/* SPI word width */
tmp = spi->bits_per_word;
if (tmp == 0) {
tmp = 8;
spi->bits_per_word = 8;
} else if (tmp > 16) {
if (tmp > 16) {
status = -EINVAL;
dev_err(&spi->dev,
"setup - "