lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[POWERPC] Fix ppc32 single-stepping out of syscalls

Browse Source 
The ppc32 kernel didn't properly set/clear the TIF_SINGLESTEP
flag, causing return from syscalls to not SIGTRAP, thus executing
one more instruction before stopping again.

This fixes it.  The ptrace code is a bit of a mess, and is overdue
for at least a -proper- 32/64 bits split and possibly more cleanups
but this minimum fix should be ok for 2.6.22

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Benjamin Herrenschmidt
2007-05-24 15:41:04 +10:00
committed by Paul Mackerras
parent 5169b8a165
commit 7d43e57764
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arch/powerpc/kernel/ptrace.c
View File

@@ -218,6 +218,7 @@ set_single_step(struct task_struct *task)
regs->msr |= MSR_SE; regs->msr |= MSR_SE;
#endif #endif
} }
set_tsk_thread_flag(task, TIF_SINGLESTEP);
} }
static inline void static inline void
@@ -233,6 +234,7 @@ clear_single_step(struct task_struct *task)
regs->msr &= ~MSR_SE; regs->msr &= ~MSR_SE;
#endif #endif
} }
clear_tsk_thread_flag(task, TIF_SINGLESTEP);
} }
#endif /* CONFIG_PPC32 */ #endif /* CONFIG_PPC32 */