lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cx82310_eth: check usb_string() return value for error

Browse Source 
Fix that usb_string() return value is not checked for error (negative value).
Also change the ignore message a bit and lower its level to info.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ondrej Zary
2010-09-11 05:39:57 +00:00
committed by David S. Miller
parent d81e27cf4e
commit 7dbfdc2390
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/usb/cx82310_eth.c
View File

@@ -138,11 +138,9 @@ static int cx82310_bind(struct usbnet *dev, struct usb_interface *intf)
struct usb_device *udev = dev->udev; struct usb_device *udev = dev->udev;
/* avoid ADSL modems - continue only if iProduct is "USB NET CARD" */ /* avoid ADSL modems - continue only if iProduct is "USB NET CARD" */
if (udev->descriptor.iProduct && if (usb_string(udev, udev->descriptor.iProduct, buf, sizeof(buf)) > 0
usb_string(udev, udev->descriptor.iProduct, buf, sizeof(buf)) && && strcmp(buf, "USB NET CARD")) {
strcmp(buf, "USB NET CARD")) { dev_info(&udev->dev, "ignoring: probably an ADSL modem\n");
dev_err(&udev->dev,
"probably an ADSL modem, use cxacru driver instead\n");
return -ENODEV; return -ENODEV;
} }