lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mtd: Make SM_FTL depend on MTD_NAND

Browse Source 
Randy Dunlap observed a build problem with the following config:

CONFIG_SM_FTL=y
CONFIG_SM_FTL_MUSEUM=y

CONFIG_MTD_NAND=m

The ECC calculation routines are then built as a module, but referenced
by the sm_ftl code in the kernel, resulting in a build failure. The
simple fix is to make CONFIG_SM_FTL depend on MTD_NAND unconditionally
-- it's pointless without hardware support anyway.

Fix some typos which Randy pointed out, too.

Reported-By: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
David Woodhouse
2010-03-08 18:45:00 -08:00
parent 1f6ca0d621
commit 7de6f798e1
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/mtd/Kconfig
View File

@@ -307,22 +307,22 @@ config SSFDC
config SM_FTL config SM_FTL
tristate "SmartMedia/xD new translation layer" tristate "SmartMedia/xD new translation layer"
depends on EXPERIMENTAL && BLOCK depends on EXPERIMENTAL && BLOCK && MTD_NAND
select MTD_BLKDEVS select MTD_BLKDEVS
help help
This enables new and very EXPERMENTAL support for SmartMedia/xD This enables new and very EXPERMENTAL support for SmartMedia/xD
FTL (Flash tanslation layer) FTL (Flash translation layer).
Write support isn't yet well tested, therefore this code IS likely to Write support isn't yet well tested, therefore this code IS likely to
eat your card, so please don't use it together with valuable data. eat your card, so please don't use it together with valuable data.
Use readonly driver (CONFIG_SSFDC) instead. Use readonly driver (CONFIG_SSFDC) instead.
config SM_FTL_MUSEUM config SM_FTL_MUSEUM
boolean "Additional Support for 1MiB and 2MiB SmartMedia cards" boolean "Additional Support for 1MiB and 2MiB SmartMedia cards"
depends on SM_FTL && MTD_NAND depends on SM_FTL
select MTD_NAND_ECC_SMC select MTD_NAND_ECC_SMC
help help
Very old SmartMedia cards need ECC to be calculated in the FTL Very old SmartMedia cards need ECC to be calculated in the FTL.
Such cards are very rare, thus enabling this option is mostly useless Such cards are very rare, thus enabling this option is mostly useless.
Also this support is completely UNTESTED. Also this support is completely UNTESTED.
config MTD_OOPS config MTD_OOPS