lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[XFS] Remove periodic logging of in-core superblock counters.

Browse Source 
xfssyncd triggers the logging of superblock counters every 30s if the
filesystem is made with lazy-count=1. This will prevent disks from idling
and spinning down as there will be a log write every 30s. With the way
counter recovery works for lazy-count=1, this code is unnecessary and
provides no real benefit, so just remove it.

SGI-PV: 980145
SGI-Modid: xfs-linux-melb:xfs-kern:30840a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Barry Naujok <bnaujok@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
This commit is contained in:
David Chinner
2008-04-17 16:49:55 +10:00
committed by Lachlan McIlroy
parent e6430037e9
commit 7e20694d91
3 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fs/xfs/linux-2.6/xfs_super.c
View File

@@ -1028,8 +1028,7 @@ xfs_sync_worker(
int error; int error;
if (!(mp->m_flags & XFS_MOUNT_RDONLY)) if (!(mp->m_flags & XFS_MOUNT_RDONLY))
error = xfs_sync(mp, SYNC_FSDATA | SYNC_BDFLUSH | SYNC_ATTR | error = xfs_sync(mp, SYNC_FSDATA | SYNC_BDFLUSH | SYNC_ATTR);
SYNC_REFCACHE | SYNC_SUPER);
mp->m_sync_seq++; mp->m_sync_seq++;
wake_up(&mp->m_wait_single_sync_task); wake_up(&mp->m_wait_single_sync_task);
} }

1
fs/xfs/linux-2.6/xfs_vfs.h
View File

@@ -49,7 +49,6 @@ typedef struct bhv_vfs_sync_work {
#define SYNC_REFCACHE 0x0040 /* prune some of the nfs ref cache */ #define SYNC_REFCACHE 0x0040 /* prune some of the nfs ref cache */
#define SYNC_REMOUNT 0x0080 /* remount readonly, no dummy LRs */ #define SYNC_REMOUNT 0x0080 /* remount readonly, no dummy LRs */
#define SYNC_IOWAIT 0x0100 /* wait for all I/O to complete */ #define SYNC_IOWAIT 0x0100 /* wait for all I/O to complete */
#define SYNC_SUPER 0x0200 /* flush superblock to disk */
/* /*
* When remounting a filesystem read-only or freezing the filesystem, * When remounting a filesystem read-only or freezing the filesystem,

13
fs/xfs/xfs_vfsops.c
View File

@@ -1316,22 +1316,9 @@ xfs_syncsub(
} }
} }
/*
* If asked, update the disk superblock with incore counter values if we
* are using non-persistent counters so that they don't get too far out
* of sync if we crash or get a forced shutdown. We don't want to force
* this to disk, just get a transaction into the iclogs....
*/
if (flags & SYNC_SUPER) {
error = xfs_log_sbcount(mp, 0);
if (error)
last_error = error;
}
/* /*
* Now check to see if the log needs a "dummy" transaction. * Now check to see if the log needs a "dummy" transaction.
*/ */
if (!(flags & SYNC_REMOUNT) && xfs_log_need_covered(mp)) { if (!(flags & SYNC_REMOUNT) && xfs_log_need_covered(mp)) {
xfs_trans_t *tp; xfs_trans_t *tp;
xfs_inode_t *ip; xfs_inode_t *ip;