lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] RCU Documentation fix

Browse Source 
Updater should use _rcu variant of list_del().

Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
Acked-by: "Paul E. McKenney" <paulmck@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Urs Thuermann
2006-07-10 04:44:06 -07:00
committed by Linus Torvalds
parent 1454aed92b
commit 82a854ec4f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/RCU/whatisRCU.txt
View File

@@ -687,8 +687,9 @@ diff shows how closely related RCU and reader-writer locking can be.
+ spin_lock(&listmutex); + spin_lock(&listmutex);
list_for_each_entry(p, head, lp) { list_for_each_entry(p, head, lp) {
if (p->key == key) { if (p->key == key) {
list_del(&p->list); - list_del(&p->list);
- write_unlock(&listmutex); - write_unlock(&listmutex);
+ list_del_rcu(&p->list);
+ spin_unlock(&listmutex); + spin_unlock(&listmutex);
+ synchronize_rcu(); + synchronize_rcu();
kfree(p); kfree(p);
@@ -736,7 +737,7 @@ Or, for those who prefer a side-by-side listing:
5 write_lock(&listmutex); 5 spin_lock(&listmutex); 5 write_lock(&listmutex); 5 spin_lock(&listmutex);
6 list_for_each_entry(p, head, lp) { 6 list_for_each_entry(p, head, lp) { 6 list_for_each_entry(p, head, lp) { 6 list_for_each_entry(p, head, lp) {
7 if (p->key == key) { 7 if (p->key == key) { 7 if (p->key == key) { 7 if (p->key == key) {
8 list_del(&p->list); 8 list_del(&p->list); 8 list_del(&p->list); 8 list_del_rcu(&p->list);
9 write_unlock(&listmutex); 9 spin_unlock(&listmutex); 9 write_unlock(&listmutex); 9 spin_unlock(&listmutex);
10 synchronize_rcu(); 10 synchronize_rcu();
10 kfree(p); 11 kfree(p); 10 kfree(p); 11 kfree(p);