lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[S390] drivers: Correct size given to memset

Browse Source 
Memset should be given the size of the structure, not the size of the pointer.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
T *x;
expression E;
@@

memset(x, E, sizeof(
+ *
 x))
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Julia Lawall
2009-12-18 17:43:22 +01:00
committed by Martin Schwidefsky
parent bb50991248
commit 83e56d0b23
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/s390/cio/fcx.c
View File

@@ -163,7 +163,7 @@ void tcw_finalize(struct tcw *tcw, int num_tidaws)
/* Add tcat to tccb. */ /* Add tcat to tccb. */
tccb = tcw_get_tccb(tcw); tccb = tcw_get_tccb(tcw);
tcat = (struct tccb_tcat *) &tccb->tca[tca_size(tccb)]; tcat = (struct tccb_tcat *) &tccb->tca[tca_size(tccb)];
memset(tcat, 0, sizeof(tcat)); memset(tcat, 0, sizeof(*tcat));
/* Calculate tcw input/output count and tcat transport count. */ /* Calculate tcw input/output count and tcat transport count. */
count = calc_dcw_count(tccb); count = calc_dcw_count(tccb);
if (tcw->w && (tcw->flags & TCW_FLAGS_OUTPUT_TIDA)) if (tcw->w && (tcw->flags & TCW_FLAGS_OUTPUT_TIDA))
@@ -269,7 +269,7 @@ EXPORT_SYMBOL(tccb_init);
*/ */
void tsb_init(struct tsb *tsb) void tsb_init(struct tsb *tsb)
{ {
memset(tsb, 0, sizeof(tsb)); memset(tsb, 0, sizeof(*tsb));
} }
EXPORT_SYMBOL(tsb_init); EXPORT_SYMBOL(tsb_init);