lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: comedi: das08: rename and rewrite DAS08_EOC

Browse Source 
The `DAS08_EOC` macro contains a mask for the "end of A/D conversion"
bit in the status register.  The logic is reverse sense in that the bit
is set to 1 while the conversion is in progress and set to 0 when the
conversion is complete.  Rename the macro to `DAS08_STATUS_AI_BUSY` and
add a comment.  Also make use of the `BIT()` macro to define the value.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ian Abbott 2015-06-05 18:30:13 +01:00 committed by Greg Kroah-Hartman
parent b00b3f769a
commit 851e5d5475
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/comedi/drivers/das08.c
View File

@ -58,7 +58,7 @@
#define DAS08_AI_MSB_REG 0x01 /* (R) AI most significant bits */
#define DAS08_AI_TRIG_REG 0x01 /* (W) AI software trigger */
#define DAS08_STATUS_REG 0x02 /* (R) status */
#define DAS08_EOC (1<<7)
#define DAS08_STATUS_AI_BUSY BIT(7) /* AI conversion in progress */
#define DAS08_IRQ (1<<3)
#define DAS08_IP(x) (((x)>>4)&0x7)
#define DAS08_CONTROL 2
@ -206,7 +206,7 @@ static int das08_ai_eoc(struct comedi_device *dev,
unsigned int status;
status = inb(dev->iobase + DAS08_STATUS_REG);
if ((status & DAS08_EOC) == 0)
if ((status & DAS08_STATUS_AI_BUSY) == 0)
return 0;
return -EBUSY;
}