lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

md: fix an unsigned compare to allow creation of bitmaps with v1.0 metadata

Browse Source 
As page->index is unsigned, this all becomes an unsigned comparison,
which almost always returns an error.

Signed-off-by: Neil Brown <neilb@suse.de>
Cc: Stable <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
NeilBrown
2007-10-22 20:45:11 -07:00
committed by Linus Torvalds
parent 0895e91d60
commit 85bfb4da8c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/md/bitmap.c
View File

@@ -274,7 +274,7 @@ static int write_sb_page(struct bitmap *bitmap, struct page *page, int wait)
if (bitmap->offset < 0) { if (bitmap->offset < 0) {
/* DATA BITMAP METADATA */ /* DATA BITMAP METADATA */
if (bitmap->offset if (bitmap->offset
+ page->index * (PAGE_SIZE/512) + (long)(page->index * (PAGE_SIZE/512))
+ size/512 > 0) + size/512 > 0)
/* bitmap runs in to metadata */ /* bitmap runs in to metadata */
return -EINVAL; return -EINVAL;