lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drm: cleanup debugfs in drm_unplug_minor()

Browse Source 
There is no reason to delay debugfs-cleanup to drm_put_minor(). We should
forbid any access to debugfs files once the device is dead. Chances they
oops once a card was unplugged are very high, anyway.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
David Herrmann
2013-10-20 18:55:43 +02:00
committed by Dave Airlie
parent a99ee459fd
commit 865fb47f7f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/drm_stub.c
View File

@@ -341,6 +341,10 @@ static void drm_unplug_minor(struct drm_minor *minor)
if (!minor || !device_is_registered(minor->kdev)) if (!minor || !device_is_registered(minor->kdev))
return; return;
#if defined(CONFIG_DEBUG_FS)
drm_debugfs_cleanup(minor);
#endif
drm_sysfs_device_remove(minor); drm_sysfs_device_remove(minor);
} }
@@ -360,10 +364,6 @@ static void drm_put_minor(struct drm_minor *minor)
DRM_DEBUG("release secondary minor %d\n", minor->index); DRM_DEBUG("release secondary minor %d\n", minor->index);
#if defined(CONFIG_DEBUG_FS)
drm_debugfs_cleanup(minor);
#endif
drm_unplug_minor(minor); drm_unplug_minor(minor);
idr_remove(&drm_minors_idr, minor->index); idr_remove(&drm_minors_idr, minor->index);