lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ACPI: replace strlen("string") with sizeof("string") -1

Browse Source 
...both give the number of chars in the string
without the '\0', as strncmp() wants,
but sizeof() is compile-time.

Reported-by: Alan Stern <stern@rowland.harvard.edu>
Cc: Pavel Vasilyev <pavel@pavlinux.ru>
Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
Len Brown
2012-07-26 21:32:01 -04:00
parent a5ca7345c1
commit 869639f9e7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/acpi/sysfs.c
View File

@@ -173,7 +173,7 @@ static int param_set_trace_state(const char *val, struct kernel_param *kp)
{ {
int result = 0; int result = 0;
if (!strncmp(val, "enable", strlen("enable"))) { if (!strncmp(val, "enable", sizeof("enable") - 1)) {
result = acpi_debug_trace(trace_method_name, trace_debug_level, result = acpi_debug_trace(trace_method_name, trace_debug_level,
trace_debug_layer, 0); trace_debug_layer, 0);
if (result) if (result)
@@ -181,7 +181,7 @@ static int param_set_trace_state(const char *val, struct kernel_param *kp)
goto exit; goto exit;
} }
if (!strncmp(val, "disable", strlen("disable"))) { if (!strncmp(val, "disable", sizeof("disable") - 1)) {
int name = 0; int name = 0;
result = acpi_debug_trace((char *)&name, trace_debug_level, result = acpi_debug_trace((char *)&name, trace_debug_level,
trace_debug_layer, 0); trace_debug_layer, 0);