lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/net: drop redundant memset

Browse Source 
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julia Lawall
2010-03-09 11:14:11 +00:00
committed by David S. Miller
parent 255f5c327e
commit 876e956f20
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/s2io.c
View File

@@ -5819,10 +5819,8 @@ static void s2io_vpd_read(struct s2io_nic *nic)
} }
} }
if ((!fail) && (vpd_data[1] < VPD_STRING_LEN)) { if ((!fail) && (vpd_data[1] < VPD_STRING_LEN))
memset(nic->product_name, 0, vpd_data[1]);
memcpy(nic->product_name, &vpd_data[3], vpd_data[1]); memcpy(nic->product_name, &vpd_data[3], vpd_data[1]);
}
kfree(vpd_data); kfree(vpd_data);
swstats->mem_freed += 256; swstats->mem_freed += 256;
} }