lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB (7452): cx88: Enable chroma AGC by default for all non-SECAM modes

Browse Source 
An enabled chroma AGC will not degrade picture quality if enabled on a
color PAL or NTSC signal with nominal signal levels. It will give a
significant color reproduction improvement if the chroma signals
diverge from nominal levels. Therefore enable chroma AGC by default
for PAL and NTSC standards.

Signed-off-by: "Frej Drejhammar <frej.drejhammar@gmail.com>"
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
This commit is contained in:
Frej Drejhammar
2008-03-23 22:43:22 -03:00
committed by Mauro Carvalho Chehab
parent 6d04203c7f
commit 87a1738919
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/video/cx88/cx88-core.c
View File

@@ -929,11 +929,10 @@ int cx88_set_tvnorm(struct cx88_core *core, v4l2_std_id norm)
dprintk(1,"set_tvnorm: MO_INPUT_FORMAT 0x%08x [old=0x%08x]\n", dprintk(1,"set_tvnorm: MO_INPUT_FORMAT 0x%08x [old=0x%08x]\n",
cxiformat, cx_read(MO_INPUT_FORMAT) & 0x0f); cxiformat, cx_read(MO_INPUT_FORMAT) & 0x0f);
/* Chroma AGC must be disabled if SECAM is used */ /* Chroma AGC must be disabled if SECAM is used, we enable it
if (norm & V4L2_STD_SECAM) by default on PAL and NTSC */
cx_andor(MO_INPUT_FORMAT, 0x40f, cxiformat); cx_andor(MO_INPUT_FORMAT, 0x40f,
else norm & V4L2_STD_SECAM ? cxiformat : cxiformat | 0x400);
cx_andor(MO_INPUT_FORMAT, 0xf, cxiformat);
// FIXME: as-is from DScaler // FIXME: as-is from DScaler
dprintk(1,"set_tvnorm: MO_OUTPUT_FORMAT 0x%08x [old=0x%08x]\n", dprintk(1,"set_tvnorm: MO_OUTPUT_FORMAT 0x%08x [old=0x%08x]\n",

2
drivers/media/video/cx88/cx88-video.c
View File

@@ -233,7 +233,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
.name = "Chroma AGC", .name = "Chroma AGC",
.minimum = 0, .minimum = 0,
.maximum = 1, .maximum = 1,
.default_value = 0x0, .default_value = 0x1,
.type = V4L2_CTRL_TYPE_BOOLEAN, .type = V4L2_CTRL_TYPE_BOOLEAN,
}, },
.reg = MO_INPUT_FORMAT, .reg = MO_INPUT_FORMAT,