seq_file: constify seq_operations
Make all seq_operations structs const, to help mitigate against revectoring user-triggerable function pointers. This is derived from the grsecurity patch, although generated from scratch because it's simpler than extracting the changes from there. Signed-off-by: James Morris <jmorris@namei.org> Acked-by: Serge Hallyn <serue@us.ibm.com> Acked-by: Casey Schaufler <casey@schaufler-ca.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
committed by
Linus Torvalds
parent
b7ed698cc9
commit
88e9d34c72
@@ -28,7 +28,7 @@ static int afs_proc_cells_show(struct seq_file *m, void *v);
|
||||
static ssize_t afs_proc_cells_write(struct file *file, const char __user *buf,
|
||||
size_t size, loff_t *_pos);
|
||||
|
||||
static struct seq_operations afs_proc_cells_ops = {
|
||||
static const struct seq_operations afs_proc_cells_ops = {
|
||||
.start = afs_proc_cells_start,
|
||||
.next = afs_proc_cells_next,
|
||||
.stop = afs_proc_cells_stop,
|
||||
@@ -70,7 +70,7 @@ static void *afs_proc_cell_volumes_next(struct seq_file *p, void *v,
|
||||
static void afs_proc_cell_volumes_stop(struct seq_file *p, void *v);
|
||||
static int afs_proc_cell_volumes_show(struct seq_file *m, void *v);
|
||||
|
||||
static struct seq_operations afs_proc_cell_volumes_ops = {
|
||||
static const struct seq_operations afs_proc_cell_volumes_ops = {
|
||||
.start = afs_proc_cell_volumes_start,
|
||||
.next = afs_proc_cell_volumes_next,
|
||||
.stop = afs_proc_cell_volumes_stop,
|
||||
@@ -95,7 +95,7 @@ static void *afs_proc_cell_vlservers_next(struct seq_file *p, void *v,
|
||||
static void afs_proc_cell_vlservers_stop(struct seq_file *p, void *v);
|
||||
static int afs_proc_cell_vlservers_show(struct seq_file *m, void *v);
|
||||
|
||||
static struct seq_operations afs_proc_cell_vlservers_ops = {
|
||||
static const struct seq_operations afs_proc_cell_vlservers_ops = {
|
||||
.start = afs_proc_cell_vlservers_start,
|
||||
.next = afs_proc_cell_vlservers_next,
|
||||
.stop = afs_proc_cell_vlservers_stop,
|
||||
@@ -119,7 +119,7 @@ static void *afs_proc_cell_servers_next(struct seq_file *p, void *v,
|
||||
static void afs_proc_cell_servers_stop(struct seq_file *p, void *v);
|
||||
static int afs_proc_cell_servers_show(struct seq_file *m, void *v);
|
||||
|
||||
static struct seq_operations afs_proc_cell_servers_ops = {
|
||||
static const struct seq_operations afs_proc_cell_servers_ops = {
|
||||
.start = afs_proc_cell_servers_start,
|
||||
.next = afs_proc_cell_servers_next,
|
||||
.stop = afs_proc_cell_servers_stop,
|
||||
|
@@ -386,9 +386,9 @@ static int table_seq_show(struct seq_file *seq, void *iter_ptr)
|
||||
return rv;
|
||||
}
|
||||
|
||||
static struct seq_operations format1_seq_ops;
|
||||
static struct seq_operations format2_seq_ops;
|
||||
static struct seq_operations format3_seq_ops;
|
||||
static const struct seq_operations format1_seq_ops;
|
||||
static const struct seq_operations format2_seq_ops;
|
||||
static const struct seq_operations format3_seq_ops;
|
||||
|
||||
static void *table_seq_start(struct seq_file *seq, loff_t *pos)
|
||||
{
|
||||
@@ -534,21 +534,21 @@ static void table_seq_stop(struct seq_file *seq, void *iter_ptr)
|
||||
}
|
||||
}
|
||||
|
||||
static struct seq_operations format1_seq_ops = {
|
||||
static const struct seq_operations format1_seq_ops = {
|
||||
.start = table_seq_start,
|
||||
.next = table_seq_next,
|
||||
.stop = table_seq_stop,
|
||||
.show = table_seq_show,
|
||||
};
|
||||
|
||||
static struct seq_operations format2_seq_ops = {
|
||||
static const struct seq_operations format2_seq_ops = {
|
||||
.start = table_seq_start,
|
||||
.next = table_seq_next,
|
||||
.stop = table_seq_stop,
|
||||
.show = table_seq_show,
|
||||
};
|
||||
|
||||
static struct seq_operations format3_seq_ops = {
|
||||
static const struct seq_operations format3_seq_ops = {
|
||||
.start = table_seq_start,
|
||||
.next = table_seq_next,
|
||||
.stop = table_seq_stop,
|
||||
|
@@ -768,7 +768,7 @@ static void jbd2_seq_history_stop(struct seq_file *seq, void *v)
|
||||
{
|
||||
}
|
||||
|
||||
static struct seq_operations jbd2_seq_history_ops = {
|
||||
static const struct seq_operations jbd2_seq_history_ops = {
|
||||
.start = jbd2_seq_history_start,
|
||||
.next = jbd2_seq_history_next,
|
||||
.stop = jbd2_seq_history_stop,
|
||||
@@ -872,7 +872,7 @@ static void jbd2_seq_info_stop(struct seq_file *seq, void *v)
|
||||
{
|
||||
}
|
||||
|
||||
static struct seq_operations jbd2_seq_info_ops = {
|
||||
static const struct seq_operations jbd2_seq_info_ops = {
|
||||
.start = jbd2_seq_info_start,
|
||||
.next = jbd2_seq_info_next,
|
||||
.stop = jbd2_seq_info_stop,
|
||||
|
@@ -1531,7 +1531,7 @@ static void *nfs_server_list_next(struct seq_file *p, void *v, loff_t *pos);
|
||||
static void nfs_server_list_stop(struct seq_file *p, void *v);
|
||||
static int nfs_server_list_show(struct seq_file *m, void *v);
|
||||
|
||||
static struct seq_operations nfs_server_list_ops = {
|
||||
static const struct seq_operations nfs_server_list_ops = {
|
||||
.start = nfs_server_list_start,
|
||||
.next = nfs_server_list_next,
|
||||
.stop = nfs_server_list_stop,
|
||||
@@ -1552,7 +1552,7 @@ static void *nfs_volume_list_next(struct seq_file *p, void *v, loff_t *pos);
|
||||
static void nfs_volume_list_stop(struct seq_file *p, void *v);
|
||||
static int nfs_volume_list_show(struct seq_file *m, void *v);
|
||||
|
||||
static struct seq_operations nfs_volume_list_ops = {
|
||||
static const struct seq_operations nfs_volume_list_ops = {
|
||||
.start = nfs_volume_list_start,
|
||||
.next = nfs_volume_list_next,
|
||||
.stop = nfs_volume_list_stop,
|
||||
|
@@ -1517,7 +1517,7 @@ static int e_show(struct seq_file *m, void *p)
|
||||
return svc_export_show(m, &svc_export_cache, cp);
|
||||
}
|
||||
|
||||
struct seq_operations nfs_exports_op = {
|
||||
const struct seq_operations nfs_exports_op = {
|
||||
.start = e_start,
|
||||
.next = e_next,
|
||||
.stop = e_stop,
|
||||
|
@@ -163,7 +163,7 @@ static void nst_seq_stop(struct seq_file *seq, void *v)
|
||||
{
|
||||
}
|
||||
|
||||
static struct seq_operations nst_seq_ops = {
|
||||
static const struct seq_operations nst_seq_ops = {
|
||||
.start = nst_seq_start,
|
||||
.next = nst_seq_next,
|
||||
.stop = nst_seq_stop,
|
||||
@@ -344,7 +344,7 @@ static void sc_seq_stop(struct seq_file *seq, void *v)
|
||||
{
|
||||
}
|
||||
|
||||
static struct seq_operations sc_seq_ops = {
|
||||
static const struct seq_operations sc_seq_ops = {
|
||||
.start = sc_seq_start,
|
||||
.next = sc_seq_next,
|
||||
.stop = sc_seq_stop,
|
||||
|
@@ -683,7 +683,7 @@ static int lockres_seq_show(struct seq_file *s, void *v)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct seq_operations debug_lockres_ops = {
|
||||
static const struct seq_operations debug_lockres_ops = {
|
||||
.start = lockres_seq_start,
|
||||
.stop = lockres_seq_stop,
|
||||
.next = lockres_seq_next,
|
||||
|
@@ -109,7 +109,7 @@ static void *nommu_region_list_next(struct seq_file *m, void *v, loff_t *pos)
|
||||
return rb_next((struct rb_node *) v);
|
||||
}
|
||||
|
||||
static struct seq_operations proc_nommu_region_list_seqop = {
|
||||
static const struct seq_operations proc_nommu_region_list_seqop = {
|
||||
.start = nommu_region_list_start,
|
||||
.next = nommu_region_list_next,
|
||||
.stop = nommu_region_list_stop,
|
||||
|
Reference in New Issue
Block a user