lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ipv6: move dereference after check in fl_free()

Browse Source 
There is a dereference before checking for NULL bug here.  Generally
free() functions should accept NULL pointers.  For example, fl_create()
can pass a NULL pointer to fl_free() on the error path.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
This commit is contained in:
Dan Carpenter
2012-08-16 16:15:02 +03:00
committed by Eric W. Biederman
parent 0625c883bc
commit 898132ae76
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
net/ipv6/ip6_flowlabel.c
View File

@@ -91,12 +91,9 @@ static struct ip6_flowlabel *fl_lookup(struct net *net, __be32 label)
static void fl_free(struct ip6_flowlabel *fl) static void fl_free(struct ip6_flowlabel *fl)
{ {
switch (fl->share) {
case IPV6_FL_S_PROCESS:
put_pid(fl->owner.pid);
break;
}
if (fl) { if (fl) {
if (fl->share == IPV6_FL_S_PROCESS)
put_pid(fl->owner.pid);
release_net(fl->fl_net); release_net(fl->fl_net);
kfree(fl->opt); kfree(fl->opt);
} }