lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

blkfront: Fix backtrace in del_gendisk

Browse Source 
The call to del_gendisk follows an non-refcounted gd->queue
pointer. We release the last ref in blk_cleanup_queue. Fixed by
reordering releases accordingly.

Signed-off-by: Daniel Stodden <daniel.stodden@citrix.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
This commit is contained in:
Daniel Stodden
2010-04-30 22:01:16 +00:00
committed by Jens Axboe
parent 5b61cb90c2
commit 89de1669ac
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/block/xen-blkfront.c
View File

@@ -1021,14 +1021,14 @@ static void blkfront_closing(struct blkfront_info *info)
/* Flush gnttab callback work. Must be done with no locks held. */ /* Flush gnttab callback work. Must be done with no locks held. */
flush_scheduled_work(); flush_scheduled_work();
blk_cleanup_queue(info->rq);
info->rq = NULL;
minor = info->gd->first_minor; minor = info->gd->first_minor;
nr_minors = info->gd->minors; nr_minors = info->gd->minors;
del_gendisk(info->gd); del_gendisk(info->gd);
xlbd_release_minors(minor, nr_minors); xlbd_release_minors(minor, nr_minors);
blk_cleanup_queue(info->rq);
info->rq = NULL;
out: out:
if (info->xbdev) if (info->xbdev)
xenbus_frontend_closed(info->xbdev); xenbus_frontend_closed(info->xbdev);