x86: coding style fixes to arch/x86/oprofile/op_model_ppro.c
no code changed: arch/x86/oprofile/op_model_ppro.o: text data bss dec hex filename 1765 0 16 1781 6f5 op_model_ppro.o.before 1765 0 16 1781 6f5 op_model_ppro.o.after md5: 71c7f68d2197d686e3d1121bc18a6b6e op_model_ppro.o.before.asm 71c7f68d2197d686e3d1121bc18a6b6e op_model_ppro.o.after.asm Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
committed by
Ingo Molnar
parent
8000a83f43
commit
8b45b72b04
@@ -1,4 +1,4 @@
|
|||||||
/**
|
/*
|
||||||
* @file op_model_ppro.h
|
* @file op_model_ppro.h
|
||||||
* pentium pro / P6 model-specific MSR operations
|
* pentium pro / P6 model-specific MSR operations
|
||||||
*
|
*
|
||||||
@@ -22,21 +22,21 @@
|
|||||||
#define NUM_COUNTERS 2
|
#define NUM_COUNTERS 2
|
||||||
#define NUM_CONTROLS 2
|
#define NUM_CONTROLS 2
|
||||||
|
|
||||||
#define CTR_IS_RESERVED(msrs,c) (msrs->counters[(c)].addr ? 1 : 0)
|
#define CTR_IS_RESERVED(msrs, c) (msrs->counters[(c)].addr ? 1 : 0)
|
||||||
#define CTR_READ(l,h,msrs,c) do {rdmsr(msrs->counters[(c)].addr, (l), (h));} while (0)
|
#define CTR_READ(l, h, msrs, c) do {rdmsr(msrs->counters[(c)].addr, (l), (h)); } while (0)
|
||||||
#define CTR_32BIT_WRITE(l,msrs,c) \
|
#define CTR_32BIT_WRITE(l, msrs, c) \
|
||||||
do {wrmsr(msrs->counters[(c)].addr, -(u32)(l), 0);} while (0)
|
do {wrmsr(msrs->counters[(c)].addr, -(u32)(l), 0); } while (0)
|
||||||
#define CTR_OVERFLOWED(n) (!((n) & (1U<<31)))
|
#define CTR_OVERFLOWED(n) (!((n) & (1U<<31)))
|
||||||
|
|
||||||
#define CTRL_IS_RESERVED(msrs,c) (msrs->controls[(c)].addr ? 1 : 0)
|
#define CTRL_IS_RESERVED(msrs, c) (msrs->controls[(c)].addr ? 1 : 0)
|
||||||
#define CTRL_READ(l,h,msrs,c) do {rdmsr((msrs->controls[(c)].addr), (l), (h));} while (0)
|
#define CTRL_READ(l, h, msrs, c) do {rdmsr((msrs->controls[(c)].addr), (l), (h)); } while (0)
|
||||||
#define CTRL_WRITE(l,h,msrs,c) do {wrmsr((msrs->controls[(c)].addr), (l), (h));} while (0)
|
#define CTRL_WRITE(l, h, msrs, c) do {wrmsr((msrs->controls[(c)].addr), (l), (h)); } while (0)
|
||||||
#define CTRL_SET_ACTIVE(n) (n |= (1<<22))
|
#define CTRL_SET_ACTIVE(n) (n |= (1<<22))
|
||||||
#define CTRL_SET_INACTIVE(n) (n &= ~(1<<22))
|
#define CTRL_SET_INACTIVE(n) (n &= ~(1<<22))
|
||||||
#define CTRL_CLEAR(x) (x &= (1<<21))
|
#define CTRL_CLEAR(x) (x &= (1<<21))
|
||||||
#define CTRL_SET_ENABLE(val) (val |= 1<<20)
|
#define CTRL_SET_ENABLE(val) (val |= 1<<20)
|
||||||
#define CTRL_SET_USR(val,u) (val |= ((u & 1) << 16))
|
#define CTRL_SET_USR(val, u) (val |= ((u & 1) << 16))
|
||||||
#define CTRL_SET_KERN(val,k) (val |= ((k & 1) << 17))
|
#define CTRL_SET_KERN(val, k) (val |= ((k & 1) << 17))
|
||||||
#define CTRL_SET_UM(val, m) (val |= (m << 8))
|
#define CTRL_SET_UM(val, m) (val |= (m << 8))
|
||||||
#define CTRL_SET_EVENT(val, e) (val |= e)
|
#define CTRL_SET_EVENT(val, e) (val |= e)
|
||||||
|
|
||||||
@@ -46,14 +46,14 @@ static void ppro_fill_in_addresses(struct op_msrs * const msrs)
|
|||||||
{
|
{
|
||||||
int i;
|
int i;
|
||||||
|
|
||||||
for (i=0; i < NUM_COUNTERS; i++) {
|
for (i = 0; i < NUM_COUNTERS; i++) {
|
||||||
if (reserve_perfctr_nmi(MSR_P6_PERFCTR0 + i))
|
if (reserve_perfctr_nmi(MSR_P6_PERFCTR0 + i))
|
||||||
msrs->counters[i].addr = MSR_P6_PERFCTR0 + i;
|
msrs->counters[i].addr = MSR_P6_PERFCTR0 + i;
|
||||||
else
|
else
|
||||||
msrs->counters[i].addr = 0;
|
msrs->counters[i].addr = 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
for (i=0; i < NUM_CONTROLS; i++) {
|
for (i = 0; i < NUM_CONTROLS; i++) {
|
||||||
if (reserve_evntsel_nmi(MSR_P6_EVNTSEL0 + i))
|
if (reserve_evntsel_nmi(MSR_P6_EVNTSEL0 + i))
|
||||||
msrs->controls[i].addr = MSR_P6_EVNTSEL0 + i;
|
msrs->controls[i].addr = MSR_P6_EVNTSEL0 + i;
|
||||||
else
|
else
|
||||||
@@ -69,7 +69,7 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs)
|
|||||||
|
|
||||||
/* clear all counters */
|
/* clear all counters */
|
||||||
for (i = 0 ; i < NUM_CONTROLS; ++i) {
|
for (i = 0 ; i < NUM_CONTROLS; ++i) {
|
||||||
if (unlikely(!CTRL_IS_RESERVED(msrs,i)))
|
if (unlikely(!CTRL_IS_RESERVED(msrs, i)))
|
||||||
continue;
|
continue;
|
||||||
CTRL_READ(low, high, msrs, i);
|
CTRL_READ(low, high, msrs, i);
|
||||||
CTRL_CLEAR(low);
|
CTRL_CLEAR(low);
|
||||||
@@ -78,14 +78,14 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs)
|
|||||||
|
|
||||||
/* avoid a false detection of ctr overflows in NMI handler */
|
/* avoid a false detection of ctr overflows in NMI handler */
|
||||||
for (i = 0; i < NUM_COUNTERS; ++i) {
|
for (i = 0; i < NUM_COUNTERS; ++i) {
|
||||||
if (unlikely(!CTR_IS_RESERVED(msrs,i)))
|
if (unlikely(!CTR_IS_RESERVED(msrs, i)))
|
||||||
continue;
|
continue;
|
||||||
CTR_32BIT_WRITE(1, msrs, i);
|
CTR_32BIT_WRITE(1, msrs, i);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* enable active counters */
|
/* enable active counters */
|
||||||
for (i = 0; i < NUM_COUNTERS; ++i) {
|
for (i = 0; i < NUM_COUNTERS; ++i) {
|
||||||
if ((counter_config[i].enabled) && (CTR_IS_RESERVED(msrs,i))) {
|
if ((counter_config[i].enabled) && (CTR_IS_RESERVED(msrs, i))) {
|
||||||
reset_value[i] = counter_config[i].count;
|
reset_value[i] = counter_config[i].count;
|
||||||
|
|
||||||
CTR_32BIT_WRITE(counter_config[i].count, msrs, i);
|
CTR_32BIT_WRITE(counter_config[i].count, msrs, i);
|
||||||
@@ -138,7 +138,7 @@ static int ppro_check_ctrs(struct pt_regs * const regs,
|
|||||||
|
|
||||||
static void ppro_start(struct op_msrs const * const msrs)
|
static void ppro_start(struct op_msrs const * const msrs)
|
||||||
{
|
{
|
||||||
unsigned int low,high;
|
unsigned int low, high;
|
||||||
int i;
|
int i;
|
||||||
|
|
||||||
for (i = 0; i < NUM_COUNTERS; ++i) {
|
for (i = 0; i < NUM_COUNTERS; ++i) {
|
||||||
@@ -153,7 +153,7 @@ static void ppro_start(struct op_msrs const * const msrs)
|
|||||||
|
|
||||||
static void ppro_stop(struct op_msrs const * const msrs)
|
static void ppro_stop(struct op_msrs const * const msrs)
|
||||||
{
|
{
|
||||||
unsigned int low,high;
|
unsigned int low, high;
|
||||||
int i;
|
int i;
|
||||||
|
|
||||||
for (i = 0; i < NUM_COUNTERS; ++i) {
|
for (i = 0; i < NUM_COUNTERS; ++i) {
|
||||||
@@ -170,11 +170,11 @@ static void ppro_shutdown(struct op_msrs const * const msrs)
|
|||||||
int i;
|
int i;
|
||||||
|
|
||||||
for (i = 0 ; i < NUM_COUNTERS ; ++i) {
|
for (i = 0 ; i < NUM_COUNTERS ; ++i) {
|
||||||
if (CTR_IS_RESERVED(msrs,i))
|
if (CTR_IS_RESERVED(msrs, i))
|
||||||
release_perfctr_nmi(MSR_P6_PERFCTR0 + i);
|
release_perfctr_nmi(MSR_P6_PERFCTR0 + i);
|
||||||
}
|
}
|
||||||
for (i = 0 ; i < NUM_CONTROLS ; ++i) {
|
for (i = 0 ; i < NUM_CONTROLS ; ++i) {
|
||||||
if (CTRL_IS_RESERVED(msrs,i))
|
if (CTRL_IS_RESERVED(msrs, i))
|
||||||
release_evntsel_nmi(MSR_P6_EVNTSEL0 + i);
|
release_evntsel_nmi(MSR_P6_EVNTSEL0 + i);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user