lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] fuse: locking fix for nlookup

Browse Source 
An inode could be returned by independent parallel lookups, in this case an
update of the lookup counter could be lost resulting in a memory leak in
userspace.

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Miklos Szeredi
2006-10-17 00:10:08 -07:00
committed by Linus Torvalds
parent 7762f5a0b7
commit 8da5ff23ce
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/fuse/dir.c
View File

@@ -163,7 +163,9 @@ static int fuse_dentry_revalidate(struct dentry *entry, struct nameidata *nd)
fuse_send_forget(fc, req, outarg.nodeid, 1); fuse_send_forget(fc, req, outarg.nodeid, 1);
return 0; return 0;
} }
spin_lock(&fc->lock);
fi->nlookup ++; fi->nlookup ++;
spin_unlock(&fc->lock);
} }
fuse_put_request(fc, req); fuse_put_request(fc, req);
if (err || (outarg.attr.mode ^ inode->i_mode) & S_IFMT) if (err || (outarg.attr.mode ^ inode->i_mode) & S_IFMT)

2
fs/fuse/inode.c
View File

@@ -195,7 +195,9 @@ struct inode *fuse_iget(struct super_block *sb, unsigned long nodeid,
} }
fi = get_fuse_inode(inode); fi = get_fuse_inode(inode);
spin_lock(&fc->lock);
fi->nlookup ++; fi->nlookup ++;
spin_unlock(&fc->lock);
fuse_change_attributes(inode, attr); fuse_change_attributes(inode, attr);
return inode; return inode;
} }