mm: clean up and kernelify shrinker registration
I can never remember what the function to register to receive VM pressure is called. I have to trace down from __alloc_pages() to find it. It's called "set_shrinker()", and it needs Your Help. 1) Don't hide struct shrinker. It contains no magic. 2) Don't allocate "struct shrinker". It's not helpful. 3) Call them "register_shrinker" and "unregister_shrinker". 4) Call the function "shrink" not "shrinker". 5) Reduce the 17 lines of waffly comments to 13, but document it properly. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Cc: David Chinner <dgc@sgi.com> Cc: Trond Myklebust <trond.myklebust@fys.uio.no> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
committed by
Linus Torvalds
parent
5ad333eb66
commit
8e1f936b73
@@ -538,6 +538,11 @@ static int shrink_dqcache_memory(int nr, gfp_t gfp_mask)
|
||||
return (dqstats.free_dquots / 100) * sysctl_vfs_cache_pressure;
|
||||
}
|
||||
|
||||
static struct shrinker dqcache_shrinker = {
|
||||
.shrink = shrink_dqcache_memory,
|
||||
.seeks = DEFAULT_SEEKS,
|
||||
};
|
||||
|
||||
/*
|
||||
* Put reference to dquot
|
||||
* NOTE: If you change this function please check whether dqput_blocks() works right...
|
||||
@@ -1870,7 +1875,7 @@ static int __init dquot_init(void)
|
||||
printk("Dquot-cache hash table entries: %ld (order %ld, %ld bytes)\n",
|
||||
nr_hash, order, (PAGE_SIZE << order));
|
||||
|
||||
set_shrinker(DEFAULT_SEEKS, shrink_dqcache_memory);
|
||||
register_shrinker(&dqcache_shrinker);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
Reference in New Issue
Block a user