lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

isci: kill scic_remote_device_get_connection_rate

Browse Source 
A function call to dereference a pointer is a tad much.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams
2011-04-29 13:20:30 -07:00
parent ab2e8f7d07
commit 8f304c36ee
5 changed files with 3 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/scsi/isci/core/scic_sds_request.c
View File

@@ -443,8 +443,7 @@ static void scu_ssp_reqeust_construct_task_context(
task_context->abort = 0; task_context->abort = 0;
task_context->priority = 0; task_context->priority = 0;
task_context->initiator_request = 1; task_context->initiator_request = 1;
task_context->connection_rate = task_context->connection_rate = target_device->connection_rate;
scic_remote_device_get_connection_rate(target_device);
task_context->protocol_engine_index = task_context->protocol_engine_index =
scic_sds_controller_get_protocol_engine_group(controller); scic_sds_controller_get_protocol_engine_group(controller);
task_context->logical_port_index = task_context->logical_port_index =

3
drivers/scsi/isci/core/scic_sds_smp_request.c
View File

@@ -193,8 +193,7 @@ static void scu_smp_request_construct_task_context(
*/ */
task_context->priority = 0; task_context->priority = 0;
task_context->initiator_request = 1; task_context->initiator_request = 1;
task_context->connection_rate = task_context->connection_rate = sci_dev->connection_rate;
scic_remote_device_get_connection_rate(sci_dev);
task_context->protocol_engine_index = task_context->protocol_engine_index =
scic_sds_controller_get_protocol_engine_group(controller); scic_sds_controller_get_protocol_engine_group(controller);
task_context->logical_port_index = task_context->logical_port_index =

3
drivers/scsi/isci/core/scic_sds_stp_request.c
View File

@@ -181,8 +181,7 @@ static void scu_sata_reqeust_construct_task_context(
task_context->abort = 0; task_context->abort = 0;
task_context->priority = SCU_TASK_PRIORITY_NORMAL; task_context->priority = SCU_TASK_PRIORITY_NORMAL;
task_context->initiator_request = 1; task_context->initiator_request = 1;
task_context->connection_rate = task_context->connection_rate = target_device->connection_rate;
scic_remote_device_get_connection_rate(target_device);
task_context->protocol_engine_index = task_context->protocol_engine_index =
scic_sds_controller_get_protocol_engine_group(controller); scic_sds_controller_get_protocol_engine_group(controller);
task_context->logical_port_index = task_context->logical_port_index =

13
drivers/scsi/isci/remote_device.c
View File

@@ -152,22 +152,9 @@ enum sci_status scic_remote_device_reset_complete(
return sci_dev->state_handlers->reset_complete_handler(sci_dev); return sci_dev->state_handlers->reset_complete_handler(sci_dev);
} }
enum sas_linkrate scic_remote_device_get_connection_rate(
struct scic_sds_remote_device *sci_dev)
{
return sci_dev->connection_rate;
}
/**
*
*
* Remote device timer requirements
*/
#define SCIC_SDS_REMOTE_DEVICE_MINIMUM_TIMER_COUNT (0) #define SCIC_SDS_REMOTE_DEVICE_MINIMUM_TIMER_COUNT (0)
#define SCIC_SDS_REMOTE_DEVICE_MAXIMUM_TIMER_COUNT (SCI_MAX_REMOTE_DEVICES) #define SCIC_SDS_REMOTE_DEVICE_MAXIMUM_TIMER_COUNT (SCI_MAX_REMOTE_DEVICES)
/** /**
* *
* @sci_dev: The remote device for which the suspend is being requested. * @sci_dev: The remote device for which the suspend is being requested.

13
drivers/scsi/isci/remote_device.h
View File

@@ -208,19 +208,6 @@ enum sci_status scic_remote_device_reset(
enum sci_status scic_remote_device_reset_complete( enum sci_status scic_remote_device_reset_complete(
struct scic_sds_remote_device *remote_device); struct scic_sds_remote_device *remote_device);
/**
* scic_remote_device_get_connection_rate() - This method simply returns the
* link rate at which communications to the remote device occur.
* @remote_device: This parameter specifies the device for which to get the
* connection rate.
*
* Return the link rate at which we transfer for the supplied remote device.
*/
enum sas_linkrate scic_remote_device_get_connection_rate(
struct scic_sds_remote_device *remote_device);
#define scic_remote_device_is_atapi(device_handle) false #define scic_remote_device_is_atapi(device_handle) false
/** /**