lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

genirq: Add missing break in __irq_set_trigger()

Browse Source 
The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.

Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Thomas Gleixner
2011-02-21 14:19:42 +01:00
parent ed4dea6e0e
commit 8fff39e069
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
kernel/irq/manage.c
View File

@@ -567,6 +567,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq,
if (chip != desc->irq_data.chip) if (chip != desc->irq_data.chip)
irq_chip_set_defaults(desc->irq_data.chip); irq_chip_set_defaults(desc->irq_data.chip);
ret = 0; ret = 0;
break;
default: default:
pr_err("setting trigger mode %lu for irq %u failed (%pF)\n", pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",
flags, irq, chip->irq_set_type); flags, irq, chip->irq_set_type);