lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

qla1280: Remove redundant NULL check before release_firmware() call

Browse Source 
release_firmware() checks for NULL pointers internally so checking
before calling the function is redundant.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Jesper Juhl
2012-04-09 22:51:36 +02:00
committed by Jiri Kosina
parent 3cc6e78777
commit 90449e5dee
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/scsi/qla1280.c
View File

@@ -4473,17 +4473,14 @@ qla1280_exit(void)
pci_unregister_driver(&qla1280_pci_driver); pci_unregister_driver(&qla1280_pci_driver);
/* release any allocated firmware images */ /* release any allocated firmware images */
for (i = 0; i < QL_NUM_FW_IMAGES; i++) { for (i = 0; i < QL_NUM_FW_IMAGES; i++) {
if (qla1280_fw_tbl[i].fw) { release_firmware(qla1280_fw_tbl[i].fw);
release_firmware(qla1280_fw_tbl[i].fw); qla1280_fw_tbl[i].fw = NULL;
qla1280_fw_tbl[i].fw = NULL;
}
} }
} }
module_init(qla1280_init); module_init(qla1280_init);
module_exit(qla1280_exit); module_exit(qla1280_exit);
MODULE_AUTHOR("Qlogic & Jes Sorensen"); MODULE_AUTHOR("Qlogic & Jes Sorensen");
MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver"); MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");