lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB (13611): radio-tea5764: Correct size given to memset

Browse Source 
Memset should be given the size of the structure, not the size of the pointer.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
T *x;
expression E;
@@

memset(x, E, sizeof(
+ *
 x))
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Julia Lawall
2009-12-10 17:17:49 -03:00
committed by Mauro Carvalho Chehab
parent ddb0b34f13
commit 909d15a70d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/radio/radio-tea5764.c
View File

@@ -314,7 +314,7 @@ static int vidioc_g_tuner(struct file *file, void *priv,
if (v->index > 0) if (v->index > 0)
return -EINVAL; return -EINVAL;
memset(v, 0, sizeof(v)); memset(v, 0, sizeof(*v));
strcpy(v->name, "FM"); strcpy(v->name, "FM");
v->type = V4L2_TUNER_RADIO; v->type = V4L2_TUNER_RADIO;
tea5764_i2c_read(radio); tea5764_i2c_read(radio);
@@ -373,7 +373,7 @@ static int vidioc_g_frequency(struct file *file, void *priv,
if (f->tuner != 0) if (f->tuner != 0)
return -EINVAL; return -EINVAL;
tea5764_i2c_read(radio); tea5764_i2c_read(radio);
memset(f, 0, sizeof(f)); memset(f, 0, sizeof(*f));
f->type = V4L2_TUNER_RADIO; f->type = V4L2_TUNER_RADIO;
if (r->tnctrl & TEA5764_TNCTRL_PUPD0) if (r->tnctrl & TEA5764_TNCTRL_PUPD0)
f->frequency = (tea5764_get_freq(radio) * 2) / 125; f->frequency = (tea5764_get_freq(radio) * 2) / 125;