lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

keys: fix sparse warning by adding __user annotation to cast

Browse Source 
Fix the following sparse warning:

      CC      security/keys/key.o
    security/keys/keyctl.c:1297:10: warning: incorrect type in argument 2 (different address spaces)
    security/keys/keyctl.c:1297:10:    expected char [noderef] <asn:1>*buffer
    security/keys/keyctl.c:1297:10:    got char *<noident>

which appears to be caused by lack of __user annotation to the cast of
a syscall argument.

Signed-off-by: James Morris <jmorris@namei.org>
Acked-by: David Howells <dhowells@redhat.com>
This commit is contained in:
James Morris
2008-12-29 14:35:35 +11:00
parent 6a94cb7306
commit 90bd49ab66
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
security/keys/keyctl.c
View File

@@ -1294,7 +1294,7 @@ asmlinkage long sys_keyctl(int option, unsigned long arg2, unsigned long arg3,
case KEYCTL_GET_SECURITY: case KEYCTL_GET_SECURITY:
return keyctl_get_security((key_serial_t) arg2, return keyctl_get_security((key_serial_t) arg2,
(char *) arg3, (char __user *) arg3,
(size_t) arg4); (size_t) arg4);
default: default: