lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sky2: Flow control frames recorded as dropped packets

Browse Source 
Thanks for your patch.  A more general solution would be to move the
rx_dropped up into sky2_receive.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Stephen Hemminger
2010-02-03 08:31:12 +00:00
committed by David S. Miller
parent 3fbd9187d0
commit 90c30335a7
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/sky2.c
View File

@@ -2404,6 +2404,9 @@ okay:
skb = receive_copy(sky2, re, length); skb = receive_copy(sky2, re, length);
else else
skb = receive_new(sky2, re, length); skb = receive_new(sky2, re, length);
dev->stats.rx_dropped += (skb == NULL);
resubmit: resubmit:
sky2_rx_submit(sky2, re); sky2_rx_submit(sky2, re);
@@ -2515,11 +2518,10 @@ static int sky2_status_intr(struct sky2_hw *hw, int to_do, u16 idx)
case OP_RXSTAT: case OP_RXSTAT:
total_packets[port]++; total_packets[port]++;
total_bytes[port] += length; total_bytes[port] += length;
skb = sky2_receive(dev, length, status); skb = sky2_receive(dev, length, status);
if (unlikely(!skb)) { if (!skb)
dev->stats.rx_dropped++;
break; break;
}
/* This chip reports checksum status differently */ /* This chip reports checksum status differently */
if (hw->flags & SKY2_HW_NEW_LE) { if (hw->flags & SKY2_HW_NEW_LE) {