lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

Browse Source 
Matthew Wilcox noticed that the debug_locks_silent use should be inverted
in DEBUG_LOCKS_WARN_ON().  This bug was causing spurious stacktraces and
incorrect failures in the locking self-test on the parisc kernel.

Bug-found-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Ingo Molnar
2006-12-22 01:08:52 -08:00
committed by Linus Torvalds
parent ba3ff12fca
commit 9127d4b1d9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/linux/debug_locks.h
View File

@@ -24,7 +24,7 @@ extern int debug_locks_off(void);
int __ret = 0; \ int __ret = 0; \
\ \
if (unlikely(c)) { \ if (unlikely(c)) { \
if (debug_locks_silent || debug_locks_off()) \ if (debug_locks_off() && !debug_locks_silent) \
WARN_ON(1); \ WARN_ON(1); \
__ret = 1; \ __ret = 1; \
} \ } \