lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

VFS: Remove redundant open-coded mode bit check in prepare_binfmt().

Browse Source 
The check in prepare_binfmt() for inode->i_mode & 0111 is redundant,
since open_exec() will already have done that.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
(cherry picked from 822dec482ced07af32c378cd936d77345786572b commit)
This commit is contained in:
Trond Myklebust
2006-08-22 20:06:03 -04:00
parent a343bb7750
commit 9167b0b9a0
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/exec.c
View File

@@ -922,12 +922,6 @@ int prepare_binprm(struct linux_binprm *bprm)
int retval; int retval;
mode = inode->i_mode; mode = inode->i_mode;
/*
* Check execute perms again - if the caller has CAP_DAC_OVERRIDE,
* generic_permission lets a non-executable through
*/
if (!(mode & 0111)) /* with at least _one_ execute bit set */
return -EACCES;
if (bprm->file->f_op == NULL) if (bprm->file->f_op == NULL)
return -EACCES; return -EACCES;