lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] gpio: drop vtable members .gpio_set_high .gpio_set_low gpio_set is enough

Browse Source 
drops gpio_set_high, gpio_set_low from the nsc_gpio_ops vtable.  While we
can't drop them from scx200_gpio (or can we?), we dont need them for new users
of the exported vtable; gpio_set(1), gpio_set(0) work fine.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Jim Cromie
2006-07-14 00:24:25 -07:00
committed by Linus Torvalds
parent b9432e4d88
commit 91e260b80d
3 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/char/pc8736x_gpio.c
View File

@@ -218,8 +218,6 @@ static struct nsc_gpio_ops pc8736x_access = {
.gpio_dump = nsc_gpio_dump, .gpio_dump = nsc_gpio_dump,
.gpio_get = pc8736x_gpio_get, .gpio_get = pc8736x_gpio_get,
.gpio_set = pc8736x_gpio_set, .gpio_set = pc8736x_gpio_set,
.gpio_set_high = pc8736x_gpio_set_high,
.gpio_set_low = pc8736x_gpio_set_low,
.gpio_change = pc8736x_gpio_change, .gpio_change = pc8736x_gpio_change,
.gpio_current = pc8736x_gpio_current .gpio_current = pc8736x_gpio_current
}; };

2
drivers/char/scx200_gpio.c
View File

@@ -41,8 +41,6 @@ struct nsc_gpio_ops scx200_access = {
.gpio_dump = nsc_gpio_dump, .gpio_dump = nsc_gpio_dump,
.gpio_get = scx200_gpio_get, .gpio_get = scx200_gpio_get,
.gpio_set = scx200_gpio_set, .gpio_set = scx200_gpio_set,
.gpio_set_high = scx200_gpio_set_high,
.gpio_set_low = scx200_gpio_set_low,
.gpio_change = scx200_gpio_change, .gpio_change = scx200_gpio_change,
.gpio_current = scx200_gpio_current .gpio_current = scx200_gpio_current
}; };

2
include/linux/nsc_gpio.h
View File

@@ -25,8 +25,6 @@ struct nsc_gpio_ops {
void (*gpio_dump) (struct nsc_gpio_ops *amp, unsigned iminor); void (*gpio_dump) (struct nsc_gpio_ops *amp, unsigned iminor);
int (*gpio_get) (unsigned iminor); int (*gpio_get) (unsigned iminor);
void (*gpio_set) (unsigned iminor, int state); void (*gpio_set) (unsigned iminor, int state);
void (*gpio_set_high)(unsigned iminor);
void (*gpio_set_low) (unsigned iminor);
void (*gpio_change) (unsigned iminor); void (*gpio_change) (unsigned iminor);
int (*gpio_current) (unsigned iminor); int (*gpio_current) (unsigned iminor);
struct device* dev; /* for dev_dbg() support, set in init */ struct device* dev; /* for dev_dbg() support, set in init */