lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

IB/uverbs: Don't decrement usecnt on error paths

Browse Source 
In error paths when destroying an object, uverbs should not decrement
associated objects' usecnt, since ib_dereg_mr(), ib_destroy_qp(),
etc. already do that.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
Roland Dreier
2006-06-17 20:37:40 -07:00
parent 77f76013e3
commit 92b1582268
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/infiniband/core/uverbs_cmd.c
View File

@@ -492,7 +492,6 @@ err_idr:
err_unreg: err_unreg:
ib_dereg_mr(mr); ib_dereg_mr(mr);
atomic_dec(&pd->usecnt);
err_up: err_up:
mutex_unlock(&ib_uverbs_idr_mutex); mutex_unlock(&ib_uverbs_idr_mutex);
@@ -986,11 +985,6 @@ err_idr:
err_destroy: err_destroy:
ib_destroy_qp(qp); ib_destroy_qp(qp);
atomic_dec(&pd->usecnt);
atomic_dec(&attr.send_cq->usecnt);
atomic_dec(&attr.recv_cq->usecnt);
if (attr.srq)
atomic_dec(&attr.srq->usecnt);
err_up: err_up:
mutex_unlock(&ib_uverbs_idr_mutex); mutex_unlock(&ib_uverbs_idr_mutex);
@@ -1888,7 +1882,6 @@ err_idr:
err_destroy: err_destroy:
ib_destroy_srq(srq); ib_destroy_srq(srq);
atomic_dec(&pd->usecnt);
err_up: err_up:
mutex_unlock(&ib_uverbs_idr_mutex); mutex_unlock(&ib_uverbs_idr_mutex);