lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arch/arm/mach-imx/mach-mx53_ard.c: add missing iounmap

Browse Source 
Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Julia Lawall
2012-01-12 10:55:12 +01:00
committed by Sascha Hauer
parent 7c0c34544d
commit 945f82f25f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
arch/arm/mach-mx5/board-mx53_ard.c
View File

@@ -189,8 +189,10 @@ static int weim_cs_config(void)
return -ENOMEM; return -ENOMEM;
iomuxc_base = ioremap(MX53_IOMUXC_BASE_ADDR, SZ_4K); iomuxc_base = ioremap(MX53_IOMUXC_BASE_ADDR, SZ_4K);
if (!iomuxc_base) if (!iomuxc_base) {
iounmap(weim_base);
return -ENOMEM; return -ENOMEM;
}
/* CS1 timings for LAN9220 */ /* CS1 timings for LAN9220 */
writel(0x20001, (weim_base + 0x18)); writel(0x20001, (weim_base + 0x18));